[BIP-909] Permissions Update Request #8

General Chat Karpatkey Updates
5

Ethereum

first batch of reviews; tx0-26. 27-189 are work in progress

Tx 0: Set Allowance for sending USDC

creates an allowance of 100 USDC per 90 days with label USDC_KPK-FEES

NOTE: i believe this is missing some decimals? intention is 100k usdc == 100000000000

Tx 1-4: Revoke AAVE/stAAVE Delegation Calls

  • revoke AAVE.delegate

  • revoke stAAVE.delegate

  • revoke AAVE.delegateByType

  • revoke stAAVE.delegateByType

Tx 5-6: Revoke Unstake via Lido’s stETH Queue

  • revoke unstETH.requestWithdrawalsWithPermit

  • revoke unstETH.requestWithdrawalsWstETHWithPermit

NOTE: unclear why revoked? also not mentioned in your forum post

Tx 8-9: Revoke sGYD

  • revoke sGYD.deposit

  • revoke sGYD.redeem

NOTE: unclear why revoked? also not mentioned in your forum post

Tx 10: Revoke sUSDS

  • revoke sUSDS.deposit

NOTE: unclear why revoked? is this simply because you want to pass a referral code on balancer’s behalf (tx#21)? also not mentioned in your forum post

Tx 11-13: Revoke Old XDai Bridge

  • revoke bridge.relayTokens

  • revoke bridge.executeSignatures

NOTE: unclear why revoked? also not mentioned in your forum post

Tx 14: Annotation Metadata

N/A

Tx 15, 17, 19-20: USDC, USDT, USDS Approvals

  • grant WETH9.approve({ForeignOmnibridge|kpkWETH|cWETHv3|UmbrellaStakeToken|kpk_ETH_PrimeV2|UmbrellaBatchHelper})

  • grant USDC.approve({})

  • grant USDT.approve({cUSDTv3|ForeignOmnibridge|stkwaEthUSDT.v1|AavePool|UmbrellaBatchHelper|spUSDT})

  • grant USDS.approve({BridgeRouter|cUSDSv3})

Tx 16: Narrow Comet Claiming Scope

  • grant CometRewards.claim({cUSDTv3|cUSDSv3|cWETHv3|cUSDCv3})

NOTE: why? previous claim was unscoped (which is fine imo), now only these 4 specific comets can be claimed?

Tx 18: Grant Sending USDC to KPK (Using Allowance)

this uses the allowance created in Tx 0 to send USDC to the KPK fees address:

  • grant USDC.transfer(KPK, ≤USDC_KPK-FEES)

Tx 21: Grant sUSDS Depositing

previously revoked in Tx 10, but now re-granting depositing but also allow for passing of a referral code:

  • grant sUSDS.deposit(*, AVATAR, *)

NOTE: why?

Tx 22: OETH?

  • grant OETH.rebaseOptIn()

NOTE: OETH is not mentioned in your forum post at all?

Tx 23

grant more scope to the AngleDistributor.claim address[] users arg. instead of only allowing array [AVATAR], now also allow for:

  • [AVATAR,AVATAR]

  • [AVATAR,AVATAR,AVATAR]

  • [AVATAR,AVATAR,AVATAR,AVATAR]

  • [AVATAR,AVATAR,AVATAR,AVATAR,AVATAR]

NOTE: why not make users unscoped?

Tx 24-25: Grant Omnibridge

  • grant ForeignOmnibridge.relayTokens({WBTC|WETH|USDT}, AVATAR, *)

  • grant ForeignOmnibridge.relayTokensAndCall(USDC, EOA, *, AVATAR)

NOTE: why is _receiver here hardcoded to EOA 0x0392A2F5Ac47388945D8c84212469F545fAE52B2??

Tx 26: Receive Gnosis Bridges

  • grant ForeignAMB.safeExecuteSignaturesWithAutoGasLimit to claim tokens {WBTC|GNO|USDC|WETH|USDT} coming from gnosis chain

Tx 27-189

wip

1 Like
[BIP XXX] Permissions Update Request #9